perf(activitylistmodel): avoid creation of temporary Activity objects
authorJyrki Gadinger <nilsding@nilsding.org>
Thu, 24 Jul 2025 14:05:18 +0000 (16:05 +0200)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 25 Jul 2025 11:02:35 +0000 (11:02 +0000)
Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
src/gui/tray/activitylistmodel.cpp

index 4a4f3f807f10b40a3c15b460769540a00a88b2ab..554559b16185eab83b3182c6c380e01dee575033 100644 (file)
@@ -543,7 +543,7 @@ void ActivityListModel::addEntriesToActivityList(const ActivityList &activityLis
     }
     endInsertRows();
 
-    const auto deselectedConflictIt = std::find_if(_finalList.constBegin(), _finalList.constEnd(), [] (const auto activity) {
+    const auto deselectedConflictIt = std::find_if(_finalList.constBegin(), _finalList.constEnd(), [] (const auto &activity) {
         return activity._syncFileItemStatus == SyncFileItem::Conflict;
     });
     const auto conflictsFound = (deselectedConflictIt != _finalList.constEnd());